tree 06ae4cf5df1bd76361484d23ee53542510730d92
parent 4625fd8efb1ede69f36bc5fe312c18155346a50f
author Nicolas Capens <capn@google.com> 1664894193 -0400
committer Nicolas Capens <nicolascapens@google.com> 1664919740 +0000

Consistently format const references

This change replaces occurrences of `T const &x` with `const T &x`.

The latter was already the predominant style. While consistency is a
strong motivation for this change in itself, this arguably also
improves readability.

The common argument for the former order of the const qualifier is that
compilers primarily perform type parsing in right-to-left order. While
there are cases where we need to pay special attention to that, types
like `unsigned int *` read more naturally as a pointer to an unsigned
integer than `int unsigned *`, i.e. we mentally group the modifier with
the basic type and read this part left-to-right. The same justification
applies to `const int &` as being easily correctly read as a reference
to a constant integer.

This also avoids confusion with `int &const` which is invalid since a
reference variable is always immutable. However `int *const` exists and
means something else than `int const *`. Writing the latter as
`const int *` makes them easier to discern.

Bug: code style formatting
Change-Id: I17188aa5ea4a20b81375e87754b64a3bcc84f0b5
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/68670
Kokoro-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>